Skip to content

DEPR: Turn ambiguous fields warnings into errors#3970

Merged
neutrinoceros merged 1 commit into
yt-project:mainfrom
neutrinoceros:fixup_field_tuples_docs
Aug 18, 2022
Merged

DEPR: Turn ambiguous fields warnings into errors#3970
neutrinoceros merged 1 commit into
yt-project:mainfrom
neutrinoceros:fixup_field_tuples_docs

Conversation

@neutrinoceros
Copy link
Copy Markdown
Member

@neutrinoceros neutrinoceros commented Jun 11, 2022 •
edited
Loading

PR Summary

Goals:

this depends on #3948 (edit: now merged)

@neutrinoceros neutrinoceros added backwards incompatible This change will change behavior deprecation deprecate features or remove deprecated ones docs release critical Highest priority (in a milestone) labels Jun 11, 2022
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Jun 11, 2022
@neutrinoceros neutrinoceros added the api-consistency naming conventions, code deduplication, informative error messages, code smells... label Jun 11, 2022
@neutrinoceros neutrinoceros changed the title DOC: fixup field tuples DEPR: finalize 4.1 deprecation cycle Jun 11, 2022
@neutrinoceros neutrinoceros mentioned this pull request Jun 11, 2022
Closed
@neutrinoceros neutrinoceros changed the title DEPR: finalize 4.1 deprecation cycle DEPR: Turn ambiguous fields warnings into errors Jun 12, 2022
@neutrinoceros neutrinoceros mentioned this pull request Jun 13, 2022
Merged
neutrinoceros
neutrinoceros commented Jun 17, 2022
View reviewed changes
Comment thread yt/fields/tests/test_ambiguous_fields.py Outdated
@neutrinoceros neutrinoceros force-pushed the fixup_field_tuples_docs branch 2 times, most recently from be6fa10 to 26ac18c Compare July 6, 2022 10:13
@neutrinoceros
Copy link
Copy Markdown
Member Author

neutrinoceros commented Jul 6, 2022 •
edited
Loading

Rebased. I'll make sure this doesn't break documentation before I open this for review.

edit: done

@neutrinoceros neutrinoceros marked this pull request as ready for review July 6, 2022 13:09
@neutrinoceros neutrinoceros mentioned this pull request Jul 12, 2022
Merged
@neutrinoceros neutrinoceros force-pushed the fixup_field_tuples_docs branch from 26ac18c to 0288f04 Compare August 5, 2022 09:41
@neutrinoceros
Copy link
Copy Markdown
Member Author

neutrinoceros commented Aug 5, 2022

rebased again to resolve a merge conflict

@neutrinoceros
Copy link
Copy Markdown
Member Author

neutrinoceros commented Aug 16, 2022

Could @matthewturk and/or @cphyc take a look ?

@neutrinoceros neutrinoceros merged commit e9023b3 into yt-project:main Aug 18, 2022
@neutrinoceros neutrinoceros deleted the fixup_field_tuples_docs branch August 18, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xarthisius Xarthisius Xarthisius approved these changes

@jzuhone jzuhone jzuhone approved these changes

Assignees

No one assigned

Labels

api-consistency naming conventions, code deduplication, informative error messages, code smells... backwards incompatible This change will change behavior deprecation deprecate features or remove deprecated ones docs release critical Highest priority (in a milestone)

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

DEPR: raise an error in case of ambiguous fields Make sure the docs use tuple field accesses

3 participants

@neutrinoceros @Xarthisius @jzuhone