BUG: skip out-of-bounds particles in ngp deposition #4604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
previously approved these changes
Jul 27, 2023
Member
matthewturk
left a comment
matthewturk
left a comment
There was a problem hiding this comment.
Looks good! If it's -1 it won't error out because we aren't disallowing wraparound, so it will not error but won't give the right answer. If we disabled wraparound but not boundscheck it should show up.
Member
Author
|
I'm confused. If we're not disallowing wraparounds, why is it erroring now ? Is "wraparound" only for negative indices ? |
Member
|
That was my understanding. |
Member
Author
|
I see. Then how about we disallow it and add the corresponding checks while we're at it ? |
Member
|
Sure, go for it.
…On Thu, Jul 27, 2023 at 6:49 AM Clément Robert ***@***.***> wrote:
I see. Then how about we disallow it and add the corresponding checks while we're at it ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Member
Author
|
there you go |
jzuhone
approved these changes
Jul 28, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
close #4603
I'm not 100% sure this is the right fix (in particular, I'm not sure if a similar check for i < 0 and j < 0 would be useful), though it does fix the issue and I'm not seeing any performance regression with my very unscientific benchmark.