正規表現エンジンが入れ子のStarでスタックオーバーフローする問題を回避#4
Merged
Conversation
Owner
|
ありがとうございます! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
「ゼロから学ぶRust」を楽しく読ませていただいています。
Rustの問題なのか(本の本質と関係あるか)どうか微妙なところですが、以前、Russ CoxのVM正規表現を自分も実装したことがあり、そのままだと入れ子になったスターを持つ
(a*)*のような正規表現でスタックオーバーフローが生じてしまいます。元の正規表現と等しいことをパッと証明はできませんし、これでどうして治るのかもよく分かってませんが、とりあえず
(r*)*となっているところを再帰的にr*へ変換すれば大丈夫だと思いこのような修正を提案します。これまで
修正後