yt/yt/core/https: handle plain http connections too #1537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now https client is able to handle "http://..." URLs too. Off by default, requires setting AllowHTTP = true in config. Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai>
|
|
|
Total
ci-viewer/20137217502/size_s (returncode 10)
Failed suites
|
yalekseev
reviewed
Dec 23, 2025
| //! Host is used for TlsDialer. | ||
| std::optional<TString> Host; | ||
| //! BypassTLS is used by HTTPS client for plain HTTP connections. | ||
| bool BypassTLS = false; |
Collaborator
There was a problem hiding this comment.
May be TryBypassTLS? It does not necessary bypasses TLS depending on dialer config.
Collaborator
|
Shipped! |
|
@yalekseev has imported your pull request. If you are a member of YTsaurus team, you can view this diff. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
to yandex/yatool
that referenced
this pull request
Jan 2, 2026
Now https client is able to handle "http://..." URLs too. Off by default, requires setting AllowHTTP = true in config. Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- * Changelog entry Type: feature Component: cpp-sdk Add option to handle both "http://" and "https://" URLs by single client. --- Pull Request resolved: ytsaurus/ytsaurus#1537 commit_hash:860222be45b8eae518dc29c4deb5ec1db3efdc17
robot-piglet
pushed a commit
to ytsaurus/ytsaurus-cpp-sdk
that referenced
this pull request
Jan 2, 2026
Now https client is able to handle "http://..." URLs too. Off by default, requires setting AllowHTTP = true in config. Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- * Changelog entry Type: feature Component: cpp-sdk Add option to handle both "http://" and "https://" URLs by single client. --- Pull Request resolved: ytsaurus/ytsaurus#1537 commit_hash:860222be45b8eae518dc29c4deb5ec1db3efdc17
robot-piglet
pushed a commit
to ydb-platform/ydb
that referenced
this pull request
Jan 2, 2026
Now https client is able to handle "http://..." URLs too. Off by default, requires setting AllowHTTP = true in config. Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- * Changelog entry Type: feature Component: cpp-sdk Add option to handle both "http://" and "https://" URLs by single client. --- Pull Request resolved: ytsaurus/ytsaurus#1537 commit_hash:860222be45b8eae518dc29c4deb5ec1db3efdc17
robot-piglet
pushed a commit
that referenced
this pull request
Jan 2, 2026
Now https client is able to handle "http://..." URLs too. Off by default, requires setting AllowHTTP = true in config. Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- * Changelog entry Type: feature Component: cpp-sdk Add option to handle both "http://" and "https://" URLs by single client. --- Pull Request resolved: #1537 commit_hash:860222be45b8eae518dc29c4deb5ec1db3efdc17
robot-piglet
pushed a commit
that referenced
this pull request
Jan 2, 2026
Now https client is able to handle "http://..." URLs too. Off by default, requires setting AllowHTTP = true in config. Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- * Changelog entry Type: feature Component: cpp-sdk Add option to handle both "http://" and "https://" URLs by single client. --- Pull Request resolved: #1537 commit_hash:860222be45b8eae518dc29c4deb5ec1db3efdc17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now https client is able to handle "http://..." URLs too.
Off by default, requires setting AllowHTTP = true in config.
Signed-off-by: Konstantin Khlebnikov khlebnikov@tracto.ai
Type: feature
Component: cpp-sdk
Add option to handle both "http://" and "https://" URLs by single client.