Change oxidized-web configuration #3458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
robertcheramy
force-pushed
the
oxidized-web-config
branch
from
a251b26 to
c0700c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request cannot be merged into master until the PR ytti/oxidized-web#325 has been released into oxidized-web, because it depends on oxidized-web understanding the new configuration passed to it.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
This pull request changes the configuration of oxidized-web, so that we can pass more arguments than just the interface to bind to, the port and an URL prefix.
This PR will close #3340 .