Skip to content

Changed PackageIDs and AssemblyName for Nuget publish #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sfurti-yb merged 2 commits into from
Jul 12, 2024
Merged

Changed PackageIDs and AssemblyName for Nuget publish #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f70514
Changed PackageIDs and AssemblyName for Nuget publish
Sfurti-yb Jul 12, 2024
2e50a78
Setting allow preRelease to false
Sfurti-yb Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<!-- Compatibility -->
<PackageVersion Include="System.Threading.Channels" Version="$(SystemVersion)" />
<PackageVersion Include="System.Collections.Immutable" Version="$(SystemVersion)" />
<PackageVersion Include="System.Text.Json" Version="$(SystemVersion)" />
<PackageVersion Include="System.Text.Json" Version="8.0.4" />
Copy link
Copy Markdown

@kneeraj kneeraj Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is SystemVersion? Why do we need to instead hardcord?

Copy link
Copy Markdown
Collaborator Author

@Sfurti-yb Sfurti-yb Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SystemVersion is also hardcoded to 8.0.0 in the file. There was an update 3 days ago to System.Text.Json package which marked that version as high vulnerability, so the build was failing until I changed it to the patched version.

<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="$(SystemVersion) " />
<PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
<PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sdk": {
"version": "8.0.100",
"rollForward": "latestMajor",
"allowPrerelease": true
"allowPrerelease": false
}
}
4 changes: 3 additions & 1 deletion src/Npgsql.DependencyInjection/Npgsql.DependencyInjection.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<PackageId>YBNpgsql.DependencyInjection</PackageId>
<Authors>Shay Rojansky</Authors>
<AssemblyName>YBNpgsql.DependencyInjection</AssemblyName>
<!-- DbDataSource was introduced to .NET in net7.0. Before that Npgsql has its own built-in copy. -->
<TargetFrameworks Condition="'$(DeveloperBuild)' != 'True'">netstandard2.0;net7.0</TargetFrameworks>
<TargetFrameworks Condition="'$(DeveloperBuild)' == 'True'">net8.0</TargetFrameworks>
<PackageTags>npgsql;postgresql;postgres;ado;ado.net;database;sql;di;dependency injection</PackageTags>
<PackageTags>npgsql;postgresql;postgres;ado;ado.net;database;sql;di;dependency injection;yugabyte</PackageTags>
<PackageReadmeFile>README.md</PackageReadmeFile>
</PropertyGroup>

Expand Down
4 changes: 3 additions & 1 deletion src/Npgsql.NetTopologySuite/Npgsql.NetTopologySuite.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<PackageId>YBNpgsql.NetTopologySuite</PackageId>
<Authors>Shay Rojansky;Yoh Deadfall</Authors>
<Description>NetTopologySuite plugin for Npgsql, allowing mapping of PostGIS geometry types to NetTopologySuite types.</Description>
<PackageTags>npgsql;postgresql;postgres;postgis;spatial;nettopologysuite;nts;ado;ado.net;database;sql</PackageTags>
<PackageTags>npgsql;postgresql;postgres;postgis;spatial;nettopologysuite;nts;ado;ado.net;database;sql;yugabyte</PackageTags>
<PackageReadmeFile>README.md</PackageReadmeFile>
<AssemblyName>YBNpgsql.NetTopologySuite</AssemblyName>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework Condition="'$(DeveloperBuild)' == 'True'">net8.0</TargetFramework>
<NoWarn>$(NoWarn);NU5104</NoWarn>
Expand Down
6 changes: 4 additions & 2 deletions src/Npgsql.NodaTime/Npgsql.NodaTime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<PackageId>YBNpgsql.NodaTime</PackageId>
<Authors>Shay Rojansky</Authors>
<Description>NodaTime plugin for Npgsql, allowing mapping of PostgreSQL date/time types to NodaTime types.</Description>
<PackageTags>npgsql;postgresql;postgres;nodatime;date;time;ado;ado;net;database;sql</PackageTags>
<Description>NodaTime plugin for NpgsqlYugabyteDB, allowing mapping of YugabyteDB date/time types to NodaTime types.</Description>
<PackageTags>npgsql;postgresql;postgres;nodatime;date;time;ado;ado;net;database;sql;yugabytedb</PackageTags>
<PackageReadmeFile>README.md</PackageReadmeFile>
<AssemblyName>YBNpgsql.NodaTime</AssemblyName>
<TargetFrameworks Condition="'$(DeveloperBuild)' != 'True'">netstandard2.0;net6.0</TargetFrameworks>
<TargetFrameworks Condition="'$(DeveloperBuild)' == 'True'">net8.0</TargetFrameworks>
<NoWarn>$(NoWarn);NPG9001</NoWarn> <!-- Converter-related APIs are experimental -->
Expand Down