YB: workaround to fix 004_pg_dump_parallel.pl test #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test 004_pg_dump_parallel.pl was introduced by commit 2b216da, which states that it teaches pg_dump to apply load-via-partition-root automatically when detecting hash-on-enum partitioning. For some reason, importing commit 96a81c1 causes this detection to stop working. This causes the test to fail. Given YB backup/restore usually uses --include-yb-metadata which causes enum oids and sort orders to be preserved, YB doesn't really need load-via-partition-root nor the automatic detection. Therefore, ignore the failing auto detection for now and just fix the test by manually passing --load-via-partition-root to pg_dump. In the future, this issue will naturally go away as YB merges to future versions beyond 96a81c1. At that point, this test change should be discarded.
hari90
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 004_pg_dump_parallel.pl was introduced by commit 2b216da, which states that it teaches pg_dump to apply load-via-partition-root automatically when detecting hash-on-enum partitioning. For some reason, importing commit 96a81c1 causes this detection to stop working. This causes the test to fail.
Given YB backup/restore usually uses --include-yb-metadata which causes enum oids and sort orders to be preserved, YB doesn't really need load-via-partition-root nor the automatic detection. Therefore, ignore the failing auto detection for now and just fix the test by manually passing --load-via-partition-root to pg_dump. In the future, this issue will naturally go away as YB merges to future versions beyond 96a81c1. At that point, this test change should be discarded.