Skip to content

[Docs] Add documentation for typeorm#26535

Merged
Sfurti-yb merged 5 commits intoyugabyte:masterfrom
Sfurti-yb:typeorm-example
Apr 11, 2025
Merged

[Docs] Add documentation for typeorm#26535
Sfurti-yb merged 5 commits intoyugabyte:masterfrom
Sfurti-yb:typeorm-example

Conversation

@Sfurti-yb
Copy link
Contributor

Changes to include CRUD example for typeORM

@Sfurti-yb Sfurti-yb requested review from ashetkar and ddhodge March 25, 2025 11:38
@CLAassistant
Copy link

CLAassistant commented Mar 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ddhodge
❌ Sfurti Sarah


Sfurti Sarah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Sfurti-yb Sfurti-yb added the area/documentation Documentation needed label Mar 25, 2025
@netlify
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit 0273155
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/67f6bc41e5d90900081018af
😎 Deploy Preview https://deploy-preview-26535--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

```
{
"compilerOptions": {
"target": "ES6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to use an old version of ECMAScript. You can use whatever you would like.

TypeORM currently ships compiled to ES2021 (but that will be increased in the next version), so using something older is not really necessary.

The important thing about tsconfig is:

{
  "experimentalDecorators": true,
  "emitDecoratorMetadata": true
}

FYI: We (TypeORM maintainers) are in the processes of rewriting our docs. The docs for the initial setup which were copied here could be re-written to take advantage of more modern JS features (we'll update them in the near future). The current instructions should still work though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alumni for the review, will make the changes accordingly

@@ -0,0 +1,106 @@
<!---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this page is for actually - it is commented out

@Sfurti-yb Sfurti-yb merged commit 5f794c0 into yugabyte:master Apr 11, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Documentation Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Documentation needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants

Comments