Skip to content

2.25.0.0-b438

tagged this 06 Dec 12:14
Summary:
PG upstream commit 4c9c359d38ff1e2de388eedd860785be6a49201c, removed the `changeDependencyOnTablespace` function call from `ATExecSetTableSpaceNoStorage` and replaced it with a common helper function, `SetRelationTableSpace` which internally makes a call to `changeDependencyOnTablespace`. This revision does the same for YugabyteDB.

  - On YB side, changeDependencyOnTablespace was introduced by YB 20281bd9c777d825cbf50c5bc0a0a615463a1944, which explicitly states in the commit message that it is borrowing code from PG ebfe2dbd6b624e2a428e14b7ee9322cc096f63f7.
  - On PG side, changeDependencyOnTablespace was introduced by PG ebfe2dbd6b624e2a428e14b7ee9322cc096f63f7.
  - During the initial YB pg15 merge 55782d561e55ef972f2470a4ae887dd791bb4a97, PG 4c9c359d38ff1e2de388eedd860785be6a49201c caused merge conflict because both YB and PG sides introduce changeDependencyOnTablespace and that commit replaces it with SetRelationTableSpace. Resolution was deferred as a YB_TODO.
  - The merge resolution is to remove changeDependencyOnTablespace because it is actually owned by PG and PG ended up replacing it.

JIRA: DB-14161

Test Plan: ./yb_build.sh --java-test org.yb.pgsql.TestPgRegressTablespaces

Reviewers: skumar, jason, yguan, aagrawal

Reviewed By: jason

Subscribers: svc_phabricator, yql

Differential Revision: https://phorge.dev.yugabyte.com/D40388
Assets 2
Loading