Skip to content

2.25.0.0-b97

@myang2021 myang2021 tagged this 08 Oct 04:16
Summary:
My recent commit 82618ef9c335fe97b1e2f996e0e2f22eeffd339c added pg_collation to
catalog cache in order to avoid error at preloading time. But the id and
index_id were incorrectly cut & pasted from its neighboring RelationRelationId
entry. This was found while I was trying to do 2.20 backport during merge
conflict resolution.

I could not come up with a test case to show incorrect behavior because the bug
is that the pg_collation catalog caches are not loaded so have zero entries (which
I confirmed via some debugging log).

Because we do not have negative caching, if not found we will just go to master
to load the entry, so there was a performance penalty.
Jira: DB-13038

Test Plan: ./yb_build.sh debug --cxx-test pgwrapper_pg_libpq-test --gtest_filter=PgLibPqTest.CollationWithPartitionedTable

Reviewers: kfranz

Reviewed By: kfranz

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D38767
Assets 2
Loading