Skip to content

2.25.1.0-b122

2.25.1.0-b122: [#24296] YSQL: Refresh output of TestPgRegressContribPostgresFdw
@karthik-ramanathan-3006 karthik-ramanathan-3006 tagged this 02 Jan 20:05 
Summary:
Upstream postgres introduced several changes/improvements to postgres_fdw between PG 11 and PG 15
which have resulted in changes to the output of its corresponding regress test.

This revision refreshes the output of the YB version of this test (`yb_pg_postgres_fdw.*`) according to these upstream Postgres changes.
Differences in output introduced by YB changes are left unchanged in this revision.
New tests introduced by upstream Postgres between versions 11 and 15 are not imported by this revision.

The upstream postgres commits of relevant FDW changes are listed below:
- Support for pushing down plan nodes such as LockRow, Sort, Limit to the remote server.
   - `d50d172e517c1d2aabff3ceb3ad3113b909c5017`: postgres_fdw: Perform the (FINAL, NULL) upperrel operations remotely.
- Changes to EXPLAIN output to make postgres_fdw EXPLAIN plans more consistent with local server.
   - `f8abb0f5e114d8c309239f0faa277b97f696d829`: postgres_fdw: suppress casts on constants in limited cases.
   - `4526951d564a7eed512b4a0ac3b5893e0a115690`: Make postgres_fdw's "Relations" output agree with the rest of EXPLAIN.
   - `6ef77cf46e81f45716ec981cb08781d426181378`: Further adjust EXPLAIN's choices of table alias names.
   - `bf39b3af6a9c6a036aae0742cf339fce662eee3a`: Further sync postgres_fdw's "Relations" output with the rest of EXPLAIN.
- Support for Bulk INSERTs in postgres_fdw.
   - `b663a4136331de6c7364226e3dbf7c88bfee7145`: Implement support for bulk inserts in postgres_fdw
- Consistency in error messages for "invalid input syntax" errors
   - `3522d0eaba5a976f09a48810dd25dff6ab3565df`: Deduplicate "invalid input syntax" messages for various types.
- Removed support for the option 'SET WITH OIDS' in creating/altering a table
   - `578b229718e8f15fa779e20f086c4b6bb3776106`: Remove WITH OIDS support, change oid catalog column visibility.
- Removed support for factorial operator
   - `76f412ab310554acb970a0b73c8d1f37f35548c6`: Remove factorial operators, leaving only the factorial() function.

Miscellaneous changes:
 - A query that attempted to move a row in a partitioned table across servers is now correctly disallowed.
   Previously, the execution of the query failed with a different error.
 - A query that previously picked a plan with a 'Hash Join' now opts for a more optimized 'Hash Semi Join' plan.

**Next steps (in future revisions)**
 - Fix YB introduced output changes.
   - Some changes are cosmetic, some changes may require code fixes.
 - Import delta of postgres_fdw tests introduced between PG 11 and PG 15.
   - This payload was not added to this revision because 1) Large volume of tests 2) Tests are interleaved among existing tests which would make reviewing objectively hard.
 - Re-enable TestPgRegressContribPostgresFdw java test.
Jira: DB-13185

Test Plan:
Skipping Jenkins as the underlying test is disabled.
Jenkins: skip

Reviewers: telgersma, fizaa

Reviewed By: telgersma

Subscribers: jason, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D40834
Assets 2
Loading