Summary:
In D36480 for PLAT-14522 we added a flag to backup script to handle prometheus HTTPS deployments that may not be present in older versions. When performing upgrades we always take a backup but use the newer code to generate backup script arguments for the old script, so the incorrect flags sometimes get passed (specifically prometheus_protocol) and backup script fails. This diff gives two fixes.
1. Allow user to skip the backup creation by passing -r=false to upgrade command
2. For versions less than 2.20.7.0-b40 and between 2024.1.0.0-b1 and 2024.1.3.0-b105 (b40 and b105 were the first versions prometheus_protocol was present in backup script) we skip passing in that parameter.
Test Plan: install 2.20.6.0 with prometheus HTTPS and run upgrade, ensure backup script works without passing prometheus_protocol
Reviewers: dshubin, sanketh, cwang
Reviewed By: cwang
Subscribers: cwang, yugaware
Differential Revision: https://phorge.dev.yugabyte.com/D41281