Skip to content

2.25.1.0-b349

2.25.1.0-b349: [#26021] YSQL: move regress schedule linter to .arclint
@jaki jaki tagged this 13 Feb 21:31 
Summary:
Commit b0c62fe6fbb93584c59666724d05e66da0bec8aa adds a lint test
"TestLintPgRegressSchedules" for regress test schedules.  These days, we
incorporate lint checks into .arclint via script-and-regex scripts in
src/lint.  Translate this lint test into src/lint/regress_schedule.sh.
Note that this now runs for all YB regress schedules, not just those in
src/postgres/src/test/regress.  A followup will be to extend the test
ordering check to not just parallel_schedule but also isolation_schedule
and perhaps extension Makefile test ordering.

Jira: DB-15351

Test Plan:
On Almalinux 8, apply patch:

    diff --git i/src/postgres/src/test/regress/yb_pg_misc_independent_1_schedule w/src/postgres/src/test/regress/yb_pg_misc_independent_1_schedule
    index ece3dc391c1..0f58d2d1b5d 100644
    --- i/src/postgres/src/test/regress/yb_pg_misc_independent_1_schedule
    +++ w/src/postgres/src/test/regress/yb_pg_misc_independent_1_schedule
    @@ -9,10 +9,10 @@ test: yb_pg_comments
     test: yb_pg_copydml
     test: yb_pg_index_including
     test: yb_pg_create_function_sql
    +test: yb_pg_namespace
     test: yb_pg_create_cast
     test: yb_pg_drop_if_exists
     test: yb_pg_case
    -test: yb_pg_namespace
     test: yb_pg_security_label
     test: yb_pg_lock
     test: yb_pg_drop_operator
    diff --git i/src/postgres/third-party-extensions/pg_hint_plan/yb_schedule w/src/postgres/third-party-extensions/pg_hint_plan/yb_schedule
    index a79d6f2b531..634c79bd8fc 100644
    --- i/src/postgres/third-party-extensions/pg_hint_plan/yb_schedule
    +++ w/src/postgres/third-party-extensions/pg_hint_plan/yb_schedule
    @@ -8,4 +8,4 @@ test: hints_anywhere
     # TODO(#TBD): These tests are broken in upstream. Once a hint is given by a statement, all
     # subsequent statements continue to use the same hints.
     # test: plpgsql
    -test: yb_hint_table
    +test: yb_hint_table # bad comment

Then on a shell with extended glob,

    arc lint src/postgres/**/yb_*schedule

should throw each of the two lint errors.

Close: #26021
Jenkins: compile only

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D41882
Assets 2
Loading