Skip to content

2.25.1.0-b61

2.25.1.0-b61: [#25296] YSQL: remove bad assertion in INSERT ON CONFLICT
@jaki jaki tagged this 19 Dec 21:05 
Summary:
In an INSERT ON CONFLICT read batching code path, there is an assertion
that can fail:

    Assert(state->num_slots >= key_count);

state->num_slots represents the number of input slots being processed
this batch.  This is typically equal to the batch size.  key_count
represents the number of keys read from the indexes.  Note index"es".
Assuming there's only one index, worst case, key_count equals num_slots.
But if there is more than one index, the worst case is that many times
num_slots.  So this assertion is faulty.  Remove it.
Jira: DB-14494

Test Plan:
On Almalinux 8, manually make sure the following fails before the
assertion is removed and succeeds without the assertion:

    ./yb_build.sh fastdebug --gcc11 \
      --java-test TestPgRegressInsertOnConflictBatch3

Reviewers: kramanathan

Reviewed By: kramanathan

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D40759
Assets 2
Loading