Skip to content

2.25.1.0-b69

2.25.1.0-b69: [#25400] YSQL: remove some outdated YB_TODOs
@jaki jaki tagged this 20 Dec 21:46 
Summary:
- Remove outdated YB_TODO in genam.c:
  - Commit b263910ba90dd273d10a8ecffa90b8affcdea529 moves ybctid out of
    ItemPointer.  RelationGetIndexScan tries to clear PG ctid and
    ybctid. ybctid is moved to xs_itup (IndexTuple) and xs_hitup
    (HeapTuple), but both are already set to NULL, so there is no extra
    clearing necessary.
- Remove outdated YB_TODO in indexcmds.c:
  - safe_index is more suited towards PG's CREATE INDEX CONCURRENTLY.
    It can make some sense for YB's, but given YB doesn't support
    transactional DDL and transaction blocks currently adopt a fixed
    catalog version for the entire transaction, YB is far from being
    able to use safe_index at the moment.  So ignore it for the YB code
    path.
  - pgstat_* is already properly merged.  Most of the code was merged in
    by YB ced7c32846e4adbe2a93ca20fc64fd648bec8851.  It explicitly
    avoids the PG phases PROGRESS_CREATEIDX_PHASE_WAIT_* and introduces
    YB phases.  PG 92942642788c9d73e4c090ee0a77603f7afbc1d7 is related
    to the PG phase, so it is irrelevant for YB.
Jira: DB-14631

Test Plan:
Close: #25400
Jenkins: skip

Reviewers: fizaa

Reviewed By: fizaa

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D40785
Assets 2
Loading