Skip to content

2.25.2.0-b111

2.25.2.0-b111: [#26309] YSQL: disallow trailing space for regress test .sql, .spec
@jaki jaki tagged this 06 Mar 23:58 
Summary:
Add trailing_whitespace lint rule to throw a message when finding
trailing whitespace in ".sql" and ".spec" regress test files.  Make sure
to not affect ".out" files (which will have trailing whitespace after
working on #26198).  Also, avoid interfering with the existing
unexpected_line_in_ported_test lint rule for ported tests: for ported
tests, only YB-owned lines should enforce that there be no trailing
whitespace.

Remove all trailing whitespace that shouldn't exist from ".sql" and
".spec" files.  The trailing_whitespace lint rule on regress tests
should pass.

Jira: DB-15656

Test Plan:
On Almalinux 8:

    #!/usr/bin/env bash
    set -u
    shopt -s globstar
    if arc lint src/postgres/**/yb.* | grep trailing_whitespace; then
      exit 1
    fi

Close: #26309

Reviewers: sanketh

Reviewed By: sanketh

Subscribers: sanketh, yql

Differential Revision: https://phorge.dev.yugabyte.com/D42304
Assets 2
Loading