Skip to content

2.25.2.0-b2

2.25.2.0-b2: [#26055] YSQL: improve linter for regress schedules
@jaki jaki tagged this 14 Feb 21:37 
Summary:
Followup on commit 5bf7cf19b8b0af82eed2da07af050971b43997ac to further
improve the linter on regress test schedules:

- Validate the test ordering of isolation regress schedules.
- Sometimes, tests in schedules directly reference the original postgres
  test.  Before, only ported tests are part of the test ordering lint
  check.  Now, both ported and original tests are part of the ordering
  check.

Fix violations of the lint rules:

- Add yb_pg_ prefix to insert-conflict-do-nothing-2.  It has some
  YB-added tests appended to the end, but the majority of the test is
  ported.  Possibly should split the YB-part out, but leave that work to
  a future commit.
- Add yb- prefix to various other tests.  Of particular note, renaming
  "ignore-intent-of-rolled-back-savepoint-cross-txn" to
  "yb-ignore-intent-of-rolled-back-savepoint-cross-txn" causes NOTICEs
  to be printed in the expected output matching the following code:

      errmsg("identifier \"%s\" will be truncated to \"%.*s\"",

  Avoid that by manually shortening the name to
  "yb-ignore-rolled-back-savepoint-intent".
- Fix order of tests in isolation schedules.

Jira: DB-15382

Test Plan:
On Almalinux 8:

    #!/usr/bin/env bash
    set -e
    shopt -s globstar
    arc lint src/postgres/**/yb_*schedule
    ./yb_build.sh fastdebug --gcc11 daemons initdb
    ./yb_build.sh fastdebug --gcc11 --java-test 'TestPgRegressIsolation#testPgRegress' --sj
    ./yb_build.sh fastdebug --gcc11 --java-test 'TestPgRegressIsolation#testPgRegressWithDelayedTxnApply' --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressIsolationWithoutWaitQueues --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressWaitQueues --sj

Close: #26055
Jenkins: test regex: TestPgRegress

Reviewers: pjain, myang

Reviewed By: myang

Subscribers: myang, yql

Differential Revision: https://phorge.dev.yugabyte.com/D41914
Assets 2
Loading