Skip to content

2.25.2.0-b236

2.25.2.0-b236: [#26557] YSQL: port Postgres COPY tests
@timothy-e timothy-e tagged this 26 Mar 19:19 
Summary:
* Move yb.port.copydml `yb_pg_misc_independent_1_schedule` to the new `yb_pg_copy_schedule`.
* Replace `yb.port.copydml` with just `copydml` and remove the `yb.port.copydml` files. There are no
* changes between the `yb.port.copydml` and `copydml`, so creating a copy just hides that fact.
* Port `yb.port.copy` and `yb.port.copy2`. Differences:
  * `ERROR:  cannot perform COPY FREEZE on a partitioned table` is replaced by `NOTICE:  cannot perform COPY FREEZE on a YugaByte table`
  * Change some `TRUNCATE`s to `DELETE FROM`s. TRUNCATEs are not transactional in Yugabyte, so
    running them inside a transaction impacts what the test expects, and potentially fail the
    transaction.
  * Skip testing inserting into a view, since that causes a crash in debug mode in Yugabyte. See #26541.

To review, it's helpful to diff the files against the PG files:
```lang=sh
diff src/postgres/src/test/regress/sql/copy.sql src/postgres/src/test/regress/sql/yb.port.copy.sql
diff src/postgres/src/test/regress/expected/copy.out src/postgres/src/test/regress/expected/yb.port.copy.out
diff src/postgres/src/test/regress/sql/copy2.sql src/postgres/src/test/regress/sql/yb.port.copy2.sql
diff src/postgres/src/test/regress/expected/copy2.out src/postgres/src/test/regress/expected/yb.port.copy2.out
```

Closes #26557
Jira: DB-15925

Test Plan:
```
./yb_build.sh --java-test TestPgRegressPgCopy
```

Jenkins: test regex: .*TestPgRegressPgCopy.*

Reviewers: jason

Reviewed By: jason

Subscribers: jason, yql

Differential Revision: https://phorge.dev.yugabyte.com/D42757
Assets 2
Loading