Skip to content

2.25.2.0-b49

2.25.2.0-b49: [#22489] CDC: Address YB_TODOs in logical replication related files
@Sumukh-Phalgaonkar Sumukh-Phalgaonkar tagged this 25 Feb 10:43 
Summary:
This diff addresses the YB_TODOs left in the logical replication related files during PG 15 merge. Following files contained these YB_TODOs:

  - **reorderbuffer.c**
PG15 introduced two-phase transactions, but these are not yet supported in YB. Hence kept the code related to streaming of partially streamed two-phase transactions inside `!IsYugaByteEnabled()` block.

  - **yb_decode.c**
The signature of the function `ReorderBufferQueueChange()` has changed in PG15. A new argument called `toast_insert` has been added. Since YB does not support on disk TOASTing, the value of this argument will be always be false.

  - **walsender.c**
A new check has been introduced in PG15 to verify that `restart_lsn` is not invalid (0) at the time of starting logical replication. We simply enable this check here.
Jira: DB-11416

Test Plan: Jenkins: test regex: .*(CDC|ReplicationSlot).*

Reviewers: skumar, siddharth.shah, stiwary, utkarsh.munjal

Reviewed By: siddharth.shah, stiwary

Subscribers: yql, ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D42112
Assets 2
Loading