Skip to content

2.25.2.0-b54

2.25.2.0-b54: [#26197] YSQL: add/consolidate pg_regress hide-details flag
@jaki jaki tagged this 26 Feb 01:43 
Summary:
pg_regress tests sometimes show output that contains unstable items such
as ybctid, oids, or catalog version.  There are some flags that have
been added to hide/suppress such output, but given there are more
instances of this coming up and they all share a similar goal, combine
them to a single flag TEST_hide_details_for_pg_regress.

- catalog version log suppression: previously covered by
  TEST_ysql_hide_catalog_version_increment_log, the logic for this is
  now covered by the new flag.  Previously, this flag was set in
  BasePgSQLTest.java; now, it is only set for BasePgRegressTest.java
  because these log messages don't need to be suppressed for other Java
  tests.
- ybctid suppression: previously covered by
  TEST_ysql_suppress_ybctid_corruption_details, the logic for this is
  now covered by the new flag.  Previously, this flag was only set in
  TestPgRegressIndex.java, but now it is set in BasePgRegressTest.java
  because if the error message ever shows up in a different regress
  test, we don't want the unstable ybctid printed.
- type oid suppression: newly covered by the flag is the suppression of
  the oid reported by the error message starting with "type not yet
  supported in Yugabyte".
- trigger relation oid suppression: newly covered by the flag is the
  suppression of the oid reported by the error message of the format
  "relation ... has no triggers"

Other changes:

- Partially port multirangetypes regress test to add coverage for the
  type oid error message.  A future change will further port more
  queries from that test.
- Update yb.orig.insert_on_conflict_multiplan*.out to no longer show an
  unstable oid.  And since unstable oid is no longer a concern, update
  the comment and reorder the test in the schedule to a more suitable
  location.
- Previously, the type oid error message used "%d" incorrectly for oid.
  Fix it to use "%u" (for the unsuppressed case).
Jira: DB-15542

Test Plan:
On Almalinux 8:

    #!/usr/bin/env bash
    set -euxo pipefail
    ./yb_build.sh fastdebug --gcc11 daemons initdb
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressIndex --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressInsertOnConflict --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressInsertOnConflictBatch0 --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressInsertOnConflictBatch1 --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressInsertOnConflictBatch2 --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressInsertOnConflictBatch3 --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressInsertOnConflictBatch9 --sj
    ./yb_build.sh fastdebug --gcc11 --java-test TestPgRegressPgTypesUDT --sj

Close: #26197

Reviewers: fizaa

Reviewed By: fizaa

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D42092
Assets 2
Loading