Skip to content

2.25.2.0-b60

2.25.2.0-b60: [PLAT-16886] Simplify AsyncTask interface in node agent
@nkhogen nkhogen tagged this 26 Feb 17:46 
Summary:
AsyncTask has only these methods.

```
type AsyncTask interface {
	// Handle is the method to be executed.
	Handle(context.Context) (*pb.DescribeTaskResponse, error)
	// CurrentTaskStatus returns the current task status.
	CurrentTaskStatus() *TaskStatus
	// String returns the identifier for this task.
	String() string
}

```

RPCResponseConverter is removed as most tasks are going to return DescribeTaskResponse anyways.

Also removed the dependency on access key info as it is not found for on-prem YNP provisioning (SSH key is optional).

Test Plan:
Created a universe successfully.

Tested on-prem manual preflight-check via RPC (python).

```
2025-02-25T02:41:03.447Z  [info] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:175 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler Starting proc (full cmd) - 'bin/ybcloud.sh' 'onprem' '--region' 'us-west-2' '--node_metadata' '{"ip":"10.9.86.40","region":"us-west-2","zone":"us-west-2a","instanceType":"nsingh-instance-1","instanceName":"nsingh-instance-1","nodeName":"detached_node"}' 'instance' 'precheck' '--custom_ssh_port' '22' '--precheck_type' 'configure' '--ssh_user' 'yugabyte' '--install_node_exporter' '--mount_points' '/mnt/d0' '--volume_size' '100' '--master_http_port' '7000' '--master_rpc_port' '7100' '--tserver_http_port' '9000' '--tserver_rpc_port' '9100' '--yb_controller_http_port' '14000' '--yb_controller_rpc_port' '18018' '--cql_proxy_http_port' '12000' '--cql_proxy_rpc_port' '9042' '--ysql_proxy_http_port' '13000' '--ysql_proxy_rpc_port' '5433' '--redis_proxy_http_port' '11000' '--redis_proxy_rpc_port' '6379' '--node_exporter_http_port' '9300' '--connection_type' 'node_agent_rpc' '--node_agent_ip' '10.9.86.40' '--node_agent_port' '9070' '--node_agent_cert_path' '/opt/yugaware/node-agent/certs/f33e3c9b-75ab-4c30-80ad-cba85646ea39/e3502a65-1a0e-4ab8-a3f5-b2b045212278/0/ca.root.crt' '--node_agent_home' '/home/yugabyte/node-agent' '--node_agent_auth_token' 'REDACTED' 'detached_node' '--remote_tmp_dir' '/tmp' - logging stdout=/tmp/shell_process_out4312110172254333686tmp, stderr=/tmp/shell_process_err7921247303750182641tmp
2025-02-25T02:41:06.473Z  [info] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:403 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler 2025-02-24 18:41:05,859 INFO wait_for_server:remote_shell.py:35: [app] Attempting connection to the remote host, retry count: 0
2025-02-25T02:41:06.474Z  [info] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:403 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler 2025-02-24 18:41:06,064 INFO run:ansible.py:239: [app] Running ansible playbook send_sudo_pass.yml against target 10.9.86.40,
2025-02-25T02:41:12.001Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:193 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler Proc stdout for 'bin/ybcloud.sh onprem --region us-west-2 instance precheck /tmp' :
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler {
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler   "nodeConfigs": [
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler     {
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler       "type": "ULIMIT_OPEN_FILES",
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler       "value": "524288"
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler     },
2025-02-25T02:41:12.002Z  [debug] ec9cc640-25b1-448a-9084-c6363f30d221 ShellProcessHandler.java:271 [TaskPool-7] com.yugabyte.yw.common.ShellProcessHandler     {
```

Also ran preflight manual.

{F335778}

Reviewers: yshchetinin, amalyshev, svarshney

Reviewed By: yshchetinin, amalyshev

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D42129
Assets 2
Loading