Skip to content

2.27.0.0-b26

@arybochkin arybochkin tagged this 26 Apr 10:00
Summary:
There's a hard-coded value for default RPC timeout which is never changed and acts as a upper bound
for every admin RPCs (actually, for every RPC inherited from ClientMasterRpcBase). This is the
original behaviour, which has never been chaged. But such a limit makes it impossible to use
timeouts large than 60 seconds for any yb-admin command.

The change removes the upper bound limit of 60 seconds: RPC controller timeout would always be set
to the specified timeout value (taken from retrier.deadline()); if retrier deadline is not set,
then the default rpc timeout would be used to configure the RPC controller's deadline.
Additionally, a new flag `yb_client_admin_rpc_timeout_sec` with default value of 60 has been added.

Jira: DB-16094

Test Plan: ./yb_build.sh --cxx-test='TEST_F(AdminCliTest, TestAdminRpcTimeout)'

Reviewers: sergei, rthallam

Reviewed By: sergei, rthallam

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D43221
Assets 2
Loading