Skip to content

2.27.0.0-b413

@basavaraj29 basavaraj29 tagged this 05 Aug 21:03
Summary:
Disabling object locking for the following wait-queue tests
1. `TestDDLsNotBlockedOnWaiters` - with object locking enabled, DDLs are blocked on DMLs waiting in the wait-queue.
2. `TestResumingWaitersDoesntBlockTabletShutdown` - This test asserts that resuming waiters from the tablet wait-queue during tablet shutdown doesn't run into lock inversion issues. For this purpose, it uses a `DROP table` which is a DDL. But with object locking enabled, the drop would wait for all in-progress DML waiters to be resumed from the queue first, thus not triggering the desired codepath.
3. `TestDeadlockRetries` - test asserts that DMLs aborted due to deadlock are retried whenever possible. Due to another known [[ https://github.com/yugabyte/yugabyte-db/issues/24877 | issue ]], we have disabled query layer retries when object locking is enabled, so the test fails with object locking enabled. We should revert this once the above issue is addressed.
Jira: DB-17772

Test Plan:
Enabled object locking, and ran the below. They fail prior to the changes in this revision
```
./yb_build.sh --cxx-test pg_wait_on_conflict-test --gtest_filter *TestDeadlockRetries*
./yb_build.sh --cxx-test pg_wait_on_conflict-test --gtest_filter *TestResumingWaitersDoesntBlockTabletShutdown*
./yb_build.sh --cxx-test pg_wait_on_conflict-test --gtest_filter *TestDDLsNotBlockedOnWaiters*
```

Reviewers: rthallam, yyan, pjain

Reviewed By: yyan, pjain

Subscribers: yql, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D45729
Assets 2
Loading