Skip to content

2.27.0.0-b567

2.27.0.0-b567: [#28572] docdb: Extra space before in flush output
@arybochkin arybochkin tagged this 15 Sep 17:49 
Summary:
The output of yb-admin flush_tablet/compact_table got changed after commit 45357417a19f9b8b922afbaeeefffb932125b21a, its format shows an unexpected difference — an extra space is introduced before the . at the end of the message. That space before the period (`tables .`) is not expected and should not present in the output.
This diff fixes this inconsistency and remove the extra space.
Before the fix (unexpected):
```
Flushed [db_dr_non_col.employees_hash_non_col [ysql_schema=public] [00004000000030008000000000004203]] tables .
```

With the fix (expected):
```
Flushed [db_dr_non_col.employees_hash_non_col [ysql_schema=public] [00004000000030008000000000004203]] tables.
```
Jira: DB-18266

Test Plan:
Jenkins

Manual:
1. Create YCQL table `test` in `ks` namespace
2. Run flush table and compact table commands from yb-admin and check the output:
```
$ yb-admin flush_table ycql.ks test
Flushed [ks.test [7a726981762742588f510671c721ecdc]] tables.

$ yb-admin flush_table ycql.ks test ADD_INDEXES
Flushed [ks.test [7a726981762742588f510671c721ecdc]] tables and associated indexes.

$ admin compact_table ycql.ks test
Compacted [ks.test [7a726981762742588f510671c721ecdc]] tables.

$ admin compact_table ycql.ks test ADD_INDEXES
Compacted [ks.test [7a726981762742588f510671c721ecdc]] tables and associated indexes.

$ admin compact_table ycql.ks test ADD_VECTOR_INDEXES
Compacted [ks.test [7a726981762742588f510671c721ecdc]] tables and associated vector indexes.

$ admin compact_table ycql.ks test ADD_INDEXES ADD_VECTOR_INDEXES
Compacted [ks.test [7a726981762742588f510671c721ecdc]] tables and associated indexes and vector indexes.
```
Please note, `ADD_VECTOR_INDEXES` is used only in test purpose and has no effect for YCQL tables, it may be used during compaction of YSQL tables only.
3. Repeat step 2 but using `flush_table_by_id/compact_table_by_id 7a726981762742588f510671c721ecdc`

Reviewers: Shubham, sergei, vishal.sharma

Reviewed By: Shubham, sergei, vishal.sharma

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D46720
Assets 2
Loading