Skip to content

2.27.0.0-b93

2.27.0.0-b93: [#27112] YSQL: fix TestPgRegressProc on Mac
@timothy-e timothy-e tagged this 12 May 11:23 
Summary:
`yb.orig.get_current_transaction_priority` has been failing on Mac for a long time, due to some small differences in output

```lang=diff
<  0.400000000 (High priority transaction)
---
>  0.400000095 (High priority transaction)
177c177
<  7 | 0.400000000 (High priority transaction)
---
>  7 | 0.400000095 (High priority transaction)
191c191
<  0.400000000 (High priority transaction)
---
>  0.400000095 (High priority transaction)
204,205c204,205
<  7 | 0.400000000 (High priority transaction)
<  8 | 0.400000000 (High priority transaction)
---
>  7 | 0.400000095 (High priority transaction)
>  8 | 0.400000095 (High priority transaction)
```

The solution is to split the output into two fields, one for the number and one for the comment, allowing the number to be presented in whatever way we choose. 2 decimal places suffices to show the meaning of the test without also testing floating point representation.

Create the test function `yb_get_current_transaction_priority_platform_independent` to do this, and then modify the test to use this function. The function is slightly complex because it needs to handle the case where `yb_get_current_transaction_priority()` returns just `(Highest Priority Transaction)`.
Jira: DB-16598

Test Plan:
Jenkins: test regex: .*TestPgRegressProc.*

```
./yb_build.sh --java-test TestPgRegressProc
```

Reviewers: kramanathan

Reviewed By: kramanathan

Subscribers: svc_phabricator, yql

Differential Revision: https://phorge.dev.yugabyte.com/D43854
Assets 2
Loading