Skip to content

2.29.0.0-b8

2.29.0.0-b8: [#28765] YSQL: deprecate yb_make_next_ddl_statement_nonincrementing
@myang2021 myang2021 tagged this 02 Oct 21:29 
Summary:
The GUC yb_make_next_ddl_statement_nonincrementing is defined as:
```
        {"yb_make_next_ddl_statement_nonincrementing", PGC_SUSET, CUSTOM_OPTIONS,
            gettext_noop("When set, the next ddl statement will not cause "
                         "catalog version to increment. This only affects "
                         "the next ddl statement and resets automatically."),
            NULL
        },
```
Consider this example

```
BEGIN;
  SET yb_make_next_ddl_statement_nonincrementing = true;
  ddl_statement_1;
  SET yb_make_next_ddl_statement_nonincrementing = true;
  ddl_statement_2;
  ddl_statement_3;
END;
```
In full refresh mode, ddl_statement_3 would have caused a full catalog cache refresh which will
allow a PG backend to see the effect of ddl_statement_1 and ddl_statement_2. In incremental refresh
mode, ddl_statement_3 only causes an incremental catalog cache refresh and the effect of
ddl_statement_1 and ddl_statement_2 are lost.

With incremental catalog cache refresh enabled by default, we should deprecate yb_make_next_ddl_statement_nonincrementing.
Jira: DB-18474

Test Plan:
./yb_build.sh release --cxx-test pg_catalog_version-test --gtest_filter PgCatalogVersionNonIncrementingDDLModeTest.NonIncrementingDDLMode/*

Backport-through: 2025.1

Reviewers: kfranz, sanketh

Reviewed By: kfranz

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D47136
Assets 2
Loading