Skip to content

2024.2.3.0-b9

2024.2.3.0-b9: [BACKPORT 2024.2][#25701] YSQL: Fix role name quoting in ysql_dumpall
@OlegLoginov OlegLoginov tagged this 19 Feb 18:58 
Summary:
Original commit: D41374 / 72293bd5272c452202e61aacd14044a9e7e23612

Before the fix in the dump the role can be quoted incorrectly:
`SELECT 1 FROM pg_roles WHERE rolname = '"Role2"' `
Here the double quoting is fixed:  ` '"Role2"' ` -> ` 'Role2' `.

Test Plan:
(1)  Java tests for `yb_backup.py`:
Note:
1. set `ENABLE_STOP_ON_YSQL_DUMP_RESTORE_ERROR=True` in `yb_backup.py`.
2. set `ENABLE_STOP_ON_YSQL_DUMP_RESTORE_ERROR = true;` in the java test file (line 84).

YB_TEST_YB_CONTROLLER=0 ./yb_build.sh --java-test org.yb.pgsql.TestYbBackup#testBackupRestoreRoles
YB_TEST_YB_CONTROLLER=0 ./yb_build.sh --java-test org.yb.pgsql.TestYbBackup#testBackupRolesWithoutUseRoles
YB_TEST_YB_CONTROLLER=0 ./yb_build.sh --java-test org.yb.pgsql.TestYbBackup#testBackupRolesWithoutRestoreRoles

(2)  `ysql_dumpall` tests:
./yb_build.sh --java-test  org.yb.pgsql.TestYsqlDump#ysqlDumpAllWithYbMetadata
./yb_build.sh --java-test  org.yb.pgsql.TestYsqlDump#ysqlDumpAllWithoutYbMetadata

Reviewers: mihnea, sanketh, hsunder

Reviewed By: hsunder

Subscribers: yql, hsunder, jason, svc_phabricator

Differential Revision: https://phorge.dev.yugabyte.com/D41950
Assets 2
Loading