Skip to content

2025.1.1.0-b20

2025.1.1.0-b20: [BACKPORT 2025.1][#27387] YSQL: Add CatalogInvalMessagesDataDebugString
@myang2021 myang2021 tagged this 25 Jun 16:10 
Summary:
Currently we have

```
  VLOG_IF(2, FLAGS_log_ysql_catalog_versions)
    << "responding (to ts "
    << req.common().ts_instance().permanent_uuid()
    << ") db catalog versions: "
    << resp.db_catalog_version_data().ShortDebugString()
    << ") db inval messages: "
    << resp.db_catalog_inval_messages_data().ShortDebugString();
```

I needed to use this log to debug an unexpected full catalog refresh but the log
of the invalidation messages are not very helpful because the hex format of the
messages are too long to fit in a glog line and gets truncated. In this case the
contents of the messages are not very useful because they are not readable. To
make this log more useful, I added `CatalogInvalMessagesDataDebugString` to
print the size of the message list instead of its contents.

Also removed some unneeded std::make_tuple calls.
Jira: DB-16921

Original commit: f8ec9a33c0bf331c36f65a315b4cfe2fbd6782e1 / D44974

Test Plan:
YB_EXTRA_MASTER_FLAGS="--vmodule=master_heartbeat_service=2" YB_EXTRA_TSERVER_FLAGS="--vmodule=heartbeater=1" ./yb_build.sh release --cxx-test pg_catalog_version-test --gtest_filter PgCatalogVersionTest.InvalMessageGarbageCollection

Look at the new test logs:

```
[m-1] I0624 02:22:48.860073 2350007 master_heartbeat_service.cc:379] vlog2: responding (to ts a0790973484040f086a6c2efcbebd612) db catalog versions: db_catalog_versions { db_oid: 1 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 4 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 5 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 13515 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 13516 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16384 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16385 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16386 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16387 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16388 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16389 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16390 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16391 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16392 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16393 current_version: 56 last_breaking_version: 56 }) db inval messages: [{1, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {4, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {5, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {13515, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {13516, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16384, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16385, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16386, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16387, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16388, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16389, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16390, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16391, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16392, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16393, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}]
[ts-3] I0624 02:22:48.860510 2348965 heartbeater.cc:504] vlog1: TryHeartbeat: got master db catalog version data: db_catalog_versions { db_oid: 1 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 4 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 5 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 13515 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 13516 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16384 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16385 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16386 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16387 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16388 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16389 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16390 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16391 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16392 current_version: 56 last_breaking_version: 56 } db_catalog_versions { db_oid: 16393 current_version: 56 last_breaking_version: 56 } db inval messages: [{1, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {4, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {5, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {13515, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {13516, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16384, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16385, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16386, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16387, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16388, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16389, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16390, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16391, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16392, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}, {16393, [{52, 48}, {53, 48}, {54, 48}, {55, 48}, {56, 48}]}]
```

Reviewers: kfranz, sanketh, mihnea

Reviewed By: sanketh

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D45003
Assets 2
Loading