Enrich discovered models with model info#3
Merged
Conversation
Signed-off-by: Xiangzhe <xiangzhedev@gmail.com>
Signed-off-by: Xiangzhe <xiangzhedev@gmail.com>
Signed-off-by: Xiangzhe <xiangzhedev@gmail.com>
4aab662 to
952d18f
Compare
Owner
|
Thanks for the implementation. I pushed a follow-up commit to keep the LiteLLM metadata enrichment while making the integration more provider-specific and extensible. What Changed
{
"modelsDiscovery": {
"modelInfoEndpoint": "/v1/model/info",
"modelInfoFormat": "litellm"
}
}
Why
QuestionCould you check whether this still covers your LiteLLM usage? In particular, is explicitly setting both of these acceptable for your setup? {
"modelInfoEndpoint": "/v1/model/info",
"modelInfoFormat": "litellm"
} |
Owner
|
I’m going to proceed with merging this since the follow-up commit keeps the LiteLLM enrichment behavior while making it opt-in and provider-specific.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2.
model_info.modeis present.embeddingmodalities.max_input_tokens,max_output_tokens, andmax_tokens.Testing
npm run typechecknpm test -- --run/bin/opencode debug config --print-logs --log-level ERROR/bin/opencode models litellm --print-logs --log-level ERROR/bin/opencode run "Reply with OK only." --model litellm/deepseek-v3.2 --print-logs --log-level ERRORNotes
npm run lintcurrently fails before linting because this repo uses ESLint 9 but only has.eslintrc.json, so ESLint cannot findeslint.config.js.