Issue #120 : safe unsafeFastStringToReadOnlyBytes. #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide a safe version of unsafeFastStringToReadOnlyBytes to be used when compiling code for environments that don't support the "unsafe" package.
fiatjaf
added a commit
to fiatjaf/glua
that referenced
this pull request
May 9, 2017
compiling from this commit here: yuin/gopher-lua#121
Owner
|
This PR just seems a workaround for your problem, I can not accept this PR as it is.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120.
Changes proposed in this pull request:
unsafeFastStringToReadOnlyBytesto be used when compiling code for environments that don't support the "unsafe" package.