Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an animated signature logo, updating the favicon.svg and adding a new Signature.astro component that features interactive path-drawing animations using the Web Animations API. The Profile card has been updated to include this component. Feedback suggests handling potential promise rejections when animations are cancelled in the Signature component and correcting the dark mode stroke color to ensure visibility. Additionally, it is recommended to retain the SVG favicon link to utilize the new animated asset instead of switching exclusively to PNG.
Contributor
📸 Screenshots for PR #51
PR screenshots folder (branch |
Wrap animation.finished in try/catch for cancellations; use light stroke in dark mode; prefer SVG favicon with PNG fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
- Replace animated favicon.svg with clean white stroke version - Move animated signature to signature-animate.svg - Remove favicon.png and associated link - Clean up dark mode styles from Signature component
yuler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignatureAstro component with stroke-draw animation (Web Animations API) and hover replay, and show it on the profile card.public/signature-animate.svgfor the standalone animated asset.Thought.astrotags and the workouts date-range inline script to satisfy ESLint.Test plan