Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive Strava API integration, enabling the fetching and local caching of athlete activities. It includes new utility scripts for syncing and testing Strava data, as well as a script to export blog posts to PDF. The changes enhance the project's capabilities by automating data retrieval and content generation, alongside updating necessary development dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Strava API integration, scripts for syncing and testing activities, a new script for exporting posts to PDF, and a draft blog post. The overall structure is good, but I've identified a critical security vulnerability in the Strava utility file where API secrets could be exposed to the client. I've provided a suggestion to enforce server-side execution for this module. Additionally, I've left a couple of medium-severity comments on the new scripts to improve error handling and code consistency. Addressing the security issue is crucial before merging.
This PR adds Strava API integration to fetch and sync athlete activities.
Key changes:
src/utils/strava.tsfor Strava API calls (with support for both Astro and Node environments).scripts/sync-strava.mjsto fetch and cache activities indata/strava/.scripts/test-strava.mjsfor manual testing.package.jsonwithstrava:testandstrava:syncscripts.