Merged
Conversation
Twitch APIが一過性で空のtitle/gameIDを返した場合に空フィールドの通知が 発射される問題を修正。両方空になった配信者は1ポーリング保留し、次回も 同じ状態が継続したら確定として通知する。 - Poller.emptyPendingで両方空の配信者を一時保留 - 単一フィールド空(意図的なクリア)は従来通り即通知 - TwitchAPI interface追加でmockテストを可能に - detector/poller/stateの単体テストを追加
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
ログ上で以下のような事象が発生:
1ポーリングのホールドオフで完全に防げる設計
Test plan