feat/fix: Amber feedback backlog — ZTD-1818/1820/1821/1822/1823/1824#11
Merged
yuzushi-dev merged 10 commits intomainfrom Apr 22, 2026
Merged
feat/fix: Amber feedback backlog — ZTD-1818/1820/1821/1822/1823/1824#11yuzushi-dev merged 10 commits intomainfrom
yuzushi-dev merged 10 commits intomainfrom
Conversation
These were never pytest test modules - they are smoke scripts with asyncio entrypoints used to probe provider factory, NIM timeout, and OpenRouter behaviour by hand. Having them under src/ meant they got included in the Docker image and cluttered the production package. Refs: docs/plans/2026-04-17-production-audit-fix-plan.md (P1-3)
…utdown Neo4jClient and MilvusVectorStore both expose close(), not aclose() (only the Redis async client has aclose). The wrong method name raised AttributeError on every Platform.shutdown(), leaving SQLAlchemy pool connections un-returned and triggering the follow-up "non-checked-in connection ... will be terminated" errors from the GC. Refs: docs/plans/2026-04-17-production-audit-fix-plan.md (P1-2)
RLS policies on tenant tables read current_setting(\"app.current_tenant\") without the missing_ok flag, so any request that reached get_db_session without a bound tenant raised "unrecognized configuration parameter" 42704 on the first query. The super-admin cross-tenant metrics path in admin/maintenance was the loudest symptom, logging "Failed to resolve document names" for every call. Fix: always emit set_config(), using an empty string when no tenant is bound. Behaviour for normal tenant-scoped requests is unchanged. Refs: docs/plans/2026-04-17-production-audit-fix-plan.md (P1-1)
Two startup guardrails: - CORS: a missing CORS_ORIGINS config used to silently fall back to "*". With DEBUG=false we now refuse to boot and raise RuntimeError, forcing the operator to set an explicit allow-list. DEBUG=true keeps the permissive default with a warning log. - SECRET_KEY_OLD: log a warning when the rotation-fallback secret is one of the well-known non-entropic dev defaults (amber-dev-key-2024, default-insecure-key). Those values defeat the dual-key keyring and leave legacy hashes forgeable. Refs: docs/plans/2026-04-17-production-audit-fix-plan.md (P1-4, P1-5)
…arity (ZTD-1824) Pending feedback endpoint was not returning is_positive, causing the admin UI to always display a ThumbsUp icon regardless of whether the feedback was positive or negative. Both polarities were already stored correctly; the field was simply missing from the API response. - api/routes/admin/feedback.py: include is_positive in get_pending_feedback response - api-admin.ts: add is_positive to FeedbackItem type - FeedbackPage.tsx: render ThumbsDown (red) or ThumbsUp (primary) based on is_positive
…ew for super admins (ZTD-1818) Admin sees only their tenant's pending feedback (already enforced by SQL WHERE). Super admin gets cross-tenant visibility: no tenant filter in query, tenant_id included in every response item and shown as a badge in the UI card. - admin/feedback.py: add Request param; skip tenant WHERE clause for super_admin - admin/feedback.py: include tenant_id in each pending-feedback response item - api-admin.ts: add tenant_id to FeedbackItem type - FeedbackPage.tsx: show tenant_id badge (amber) on cards when user is super admin
…r (ZTD-1823) Users were permanently blocked from changing their feedback by a frontend disabled state. Backend now supports smart upsert semantics: - Same polarity re-submit (PENDING/NONE): updates comment/score in place - Polarity flip (PENDING/NONE): deletes old record, creates new PENDING - VERIFIED/REJECTED records: never touched; new PENDING record created Frontend: removed permanent disabled state on thumbs buttons (only disabled while request is in-flight), allowing users to change their feedback. Feedback id is now generated explicitly on construction (not deferred to flush) to ensure it is available before DB commit.
…D-1821)
The document detail page previously showed only RAG metadata (chunks, entities,
relationships). Users had no way to view the actual source document content.
The API endpoint GET /documents/{id}/file already existed. This change adds:
- DocumentViewer component: fetches the file with auth, renders inline
- PDF / HTML → <iframe> with blob URL
- Markdown → ReactMarkdown with GFM
- Plain text → <pre> block
- Unknown types → download fallback
- "View Document" button in the DocumentDetailPage header
- Download button always available inside the viewer dialog
…D-1822) The client view (/amber/chat) had no way to access past conversations. The backend GET /chat/history endpoint existed but was unwired in the UI. - ChatHistoryPanel: slide-in panel from the left with paginated conversation list, active conversation highlight, delete with confirmation, and "New conversation" shortcut - ClientLayout: adds History icon button in header that toggles the panel - Backend already correct; tests confirm user+tenant scoping and response shape
… context (ZTD-1820) Partners managing multiple setups experienced context bleed: ConversationSummaries from session A (e.g., client A config) were injected into session B, causing incorrect context and hallucinated answers about the wrong configuration. Root cause: get_recent_summaries() was called on every generation request and its results injected into the prompt under "PAST CONVERSATIONS". This is cross-session by definition — the summaries span all past conversations for the user. Fix: remove get_recent_summaries() injection from both the standard RAG path and the streaming path. UserFacts (long-term user profile) are intentionally kept as they represent persistent knowledge about who the user is, not what they discussed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "SECRET_KEY_OLD is set to a known dev default (%s). " | ||
| "Complete the rotation and unset SECRET_KEY_OLD, or replace " | ||
| "it with the actual previous secret being retired.", | ||
| settings.secret_key_old[:12] + "…", |
yuzushi-dev
added a commit
that referenced
this pull request
Apr 22, 2026
- DocumentViewer: tighten HTML iframe sandbox from allow-same-origin to '' to prevent XSS via arbitrary HTML documents - ChatHistoryPanel: remove unused bottomRef (dead code from incomplete IntersectionObserver implementation) - admin/feedback.py: remove redundant query alias (query = base_query) - feedback.py: set golden_status=PENDING on same-polarity upsert so re-submitted feedback is re-queued for admin review - test_feedback_multiple_submissions: assert golden_status after upsert - test_memory_session_isolation: add source-inspection regression guard that fails if get_recent_summaries re-appears in generation_service
yuzushi-dev
added a commit
that referenced
this pull request
Apr 22, 2026
- DocumentViewer: tighten HTML iframe sandbox from allow-same-origin to '' to prevent XSS via arbitrary HTML documents - ChatHistoryPanel: remove unused bottomRef (dead code from incomplete IntersectionObserver implementation) - admin/feedback.py: remove redundant query alias (query = base_query) - feedback.py: set golden_status=PENDING on same-polarity upsert so re-submitted feedback is re-queued for admin review - test_feedback_multiple_submissions: assert golden_status after upsert - test_memory_session_isolation: add source-inspection regression guard that fails if get_recent_summaries re-appears in generation_service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements 6 items from the Amber feedback backlog (ZTD-1817).
is_positivewas missing from admin API responseConversationSummariesfrom past sessions no longer injected into new prompts;UserFacts(user profile) retainedTest plan
pytest tests/unit/test_feedback_*.py tests/unit/test_document_content_type.py tests/unit/test_chat_history_endpoint.py tests/unit/test_memory_session_isolation.py)/amber/chat, click History icon, verify past conversations listed and clickable🤖 Generated with Claude Code