fix location access issue#49
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb29237d6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (getConfigStore().config.hasGrantedLocationAccess) { | ||
| this.start(); |
There was a problem hiding this comment.
This visibility-gated restart never runs in practice because hasGrantedLocationAccess is initialized to false and this commit does not add any write path that flips it to true (or emits the new config event). In the current flow, once the page is hidden and stop() clears the watch, returning to the page will not restart geolocation even for users who already granted permission, so location updates silently stop until they tap Locate again.
Useful? React with 👍 / 👎.
1 participant
No description provided.