ci(trunk): fix duplicate Trunk Check context blocking PRs#759
Merged
Conversation
… check context The workflow and job were both named 'Trunk Check', colliding with the check that trunk-io/trunk-action posts (also 'Trunk Check'). Two identically-named check-runs confuse strict branch protection (required context 'Trunk Check'), leaving PRs stuck in BLOCKED even when all checks pass. Renaming to the org-conventional 'Trunk Code Quality' (matching other repos) leaves the action's 'Trunk Check' as the sole required context. Fixes #757.
Deploying zsh with
|
| Latest commit: |
01091cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffc6cd88.zsh.pages.dev |
| Branch Preview URL: | https://bug-trunk-check-dup-context.zsh.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves duplicate Trunk check context naming in CI so strict branch protection can uniquely match the required Trunk Check status emitted by the Trunk action.
Changes:
- Renames the workflow from
Trunk ChecktoTrunk Code Quality. - Renames the workflow job display name to
Trunk Code Quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (#757)
trunk-check.ymlnamed both the workflow and the jobTrunk Check. That collides with the check-runtrunk-io/trunk-actionposts (also namedTrunk Check), producing two identically-namedgithub-actionscheck-runs on every PR. Under strict branch protection with required contextTrunk Check, GitHub can't disambiguate and leaves PRsBLOCKEDeven when all checks pass (observed on automated zsh-lint docs-sync PRs #756, #758 — both needed admin override).Fix
Rename the workflow and job to
Trunk Code Quality(the org-conventional name per CLAUDE.md, and whatz-shell/zsh-lintalready uses). The action's postedTrunk Checkcheck-run then remains the single match for the required context — no more collision, no admin override needed.No change to branch protection required.
Verify