Fix zCobol test cases with muliply packed issue#777
Merged
Conversation
abekornelis
added
bug
Zaneham
approved these changes
May 2, 2026
Contributor
Zaneham
left a comment
Zaneham
left a comment
There was a problem hiding this comment.
Approved. Happy for this to merge :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #759
For now I have changed the test cases - they were multiplying numbers that are simply too large for MP to handle.
I.e. MP requires operand1 to have as many leading bytes of zeroes (2 packed zeroes each) as the entire length of operand2. The operand2 in this case was assembled as 4 bytes, but operand 1 did not have 8 leading zeroes.