Conversation
- Fix MedFlamingo.generate() to pass inputs_embeds so xattn visual conditioning is actually applied (was passing raw input_ids) - Fix MedFlamingo.__init__() to initialise self._fc = None when no dataset is supplied (prevents AttributeError in forward()) - VQARADDataset.prepare_metadata(): filter rows whose image file is missing from disk (14 OSF images never existed); logs a warning - Remove duplicate VQARADDataset import in datasets/__init__.py - Remove duplicate MedicalVQATask import in tasks/__init__.py - medical_vqa_task.py: add module docstring, full Google-style class docstring, and __call__ docstring with Args / Returns / Example - examples/vqarad_medvqa_medflamingo.py: full rewrite with three ablation axes (cross_attn_every_n_layers, num_resampler_tokens, freeze_vision), --ablation CLI flag, helper functions, usage docs - tests/core/test_medflamingo.py: remove all TODO stubs; add isolated MedicalVQATask unit tests and test_generate_uses_inputs_embeds; fix Patient construction to use Polars DataFrame API Contributors: Zarmeen Hasan (zarmeen2), Camdyn Zook (camdynz2)
Feat/medflamingo full pipeline
zarmeen2
deleted the
feat/docs-example-repo-clean-up-and-testing-suggestions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.