Skip to content

Conversation

@jimsynz
Copy link
Contributor

@jimsynz jimsynz commented Nov 20, 2020

This just bypasses the shell prompt so that it can be used non-interactively.

I did not add an acceptance test for this because I can't figure out how to, but am happy to do so with a few pointers.

Contributor checklist

  • My commit messages follow the Conventional Commit Message Format
    For example: fix: Multiply by appropriate coefficient, or
    feat(Calculator): Correctly preserve history
    Any explanation or long form information in your commit message should be
    in a separate paragraph, separated by a blank line from the primary message
  • Bug fixes include regression tests
  • Features include unit/acceptance tests

This just bypasses the shell prompt so that it can be used non-interactively.
@sourcelevel-bot
Copy link

Hello, @jimsynz! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 141

  • 1 of 9 (11.11%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 84.806%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mix/tasks/git_ops.release.ex 1 9 11.11%
Totals Coverage Status
Change from base Build 139: -0.9%
Covered Lines: 240
Relevant Lines: 283

💛 - Coveralls

@zachdaniel
Copy link
Owner

LGTM, will merge and release this weekend

@zachdaniel
Copy link
Owner

🚀 Thank you for your contribution! 🚀

@zachdaniel zachdaniel merged commit f84c71e into zachdaniel:master Nov 21, 2020
@zachdaniel
Copy link
Owner

Published as version 2.1.0

zachdaniel pushed a commit that referenced this pull request Nov 21, 2020
This just bypasses the shell prompt so that it can be used non-interactively.

Co-authored-by: James Harton <james@harton.nz>
@jimsynz jimsynz deleted the add-yes-option-to-mix-release branch November 23, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants