Skip to content

Conversation

@kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Nov 20, 2020

List of changes:

  • Use common source url
  • Add changelog link to hex info page
  • Add source reference to html doc
  • Add changelog to html doc
  • Badges and more badges!
  • Indent list
  • Fix module config syntax

Contributor checklist

  • My commit messages follow the Conventional Commit Message Format
    For example: fix: Multiply by appropriate coefficient, or
    feat(Calculator): Correctly preserve history
    Any explanation or long form information in your commit message should be
    in a separate paragraph, separated by a blank line from the primary message
  • Bug fixes include regression tests
  • Features include unit/acceptance tests

List of changes:

- Use common source url
- Add changelog link to hex info page
- Add source reference to html doc
- Add changelog to html doc
- Badges and more badges!
- Indent list
- Fix module config syntax
* https://github.com/mpanarin/versioce
* https://github.com/glasnoster/eliver
* https://github.com/oo6/mix-bump
* https://github.com/mpanarin/versioce

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t use literal URLs without angle brackets

* https://github.com/mpanarin/versioce
* https://github.com/glasnoster/eliver
* https://github.com/oo6/mix-bump
* https://github.com/mpanarin/versioce

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* https://github.com/oo6/mix-bump
* https://github.com/mpanarin/versioce
* https://github.com/glasnoster/eliver
* https://github.com/oo6/mix-bump

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t use literal URLs without angle brackets

* https://github.com/oo6/mix-bump
* https://github.com/mpanarin/versioce
* https://github.com/glasnoster/eliver
* https://github.com/oo6/mix-bump

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* https://github.com/glasnoster/eliver
* https://github.com/oo6/mix-bump
* https://github.com/mpanarin/versioce
* https://github.com/glasnoster/eliver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t use literal URLs without angle brackets

* https://github.com/glasnoster/eliver
* https://github.com/oo6/mix-bump
* https://github.com/mpanarin/versioce
* https://github.com/glasnoster/eliver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* A task to build a compliant commit
* Validation of commits
* Automatically link to the PR that merged a given commit in the changelog
* A hundred other things I forgot to write down while writing the initial version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* Automatically parse issue numbers and github mentions into the correct format, linking the issue
* A task to build a compliant commit
* Validation of commits
* Automatically link to the PR that merged a given commit in the changelog

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* More tests
* Automatically parse issue numbers and github mentions into the correct format, linking the issue
* A task to build a compliant commit
* Validation of commits

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* A hundred other things I forgot to write down while writing the initial version
* More tests
* Automatically parse issue numbers and github mentions into the correct format, linking the issue
* A task to build a compliant commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* Automatically link to the PR that merged a given commit in the changelog
* A hundred other things I forgot to write down while writing the initial version
* More tests
* Automatically parse issue numbers and github mentions into the correct format, linking the issue

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

* Validation of commits
* Automatically link to the PR that merged a given commit in the changelog
* A hundred other things I forgot to write down while writing the initial version
* More tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation before bullet: remove 2 spaces

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 9 possible new issues (including those that may have been commented here).
  • 11 fixed issues! 🎉

See more details about this review.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 142

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.714%

Totals Coverage Status
Change from base Build 139: 0.0%
Covered Lines: 240
Relevant Lines: 280

💛 - Coveralls

@zachdaniel
Copy link
Owner

🚀 Thank you for your contribution! 🚀

@zachdaniel zachdaniel merged commit 257310b into zachdaniel:master Nov 21, 2020
@zachdaniel
Copy link
Owner

Published as version 2.1.0

zachdaniel pushed a commit that referenced this pull request Nov 21, 2020
List of changes:

- Use common source url
- Add changelog link to hex info page
- Add source reference to html doc
- Add changelog to html doc
- Badges and more badges!
- Indent list
- Fix module config syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants