style: Fix credo warnings #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SourceLevel has finished reviewing this Pull Request and has found:
|
kianmeng
force-pushed
the
fix-credo-warnings
branch
from
00103e7 to
f188fa1
Compare
zachdaniel
approved these changes
Nov 21, 2020
zachdaniel
pushed a commit
that referenced
this pull request
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
For example:
fix: Multiply by appropriate coefficient, orfeat(Calculator): Correctly preserve historyAny explanation or long form information in your commit message should be
in a separate paragraph, separated by a blank line from the primary message