fix(api): add Fastify request type augmentation to eliminate as any casts#6
Open
Gmymymy wants to merge 1 commit into
Open
fix(api): add Fastify request type augmentation to eliminate as any casts#6Gmymymy wants to merge 1 commit into
as any casts#6Gmymymy wants to merge 1 commit into
Conversation
… casts Add `packages/api/src/types/fastify.d.ts` to extend the Fastify `FastifyRequest` interface with `user`, `authSession`, and `workspaceMember` properties that middleware attaches at runtime. This replaces all `(request as any).user`, `(request as any).authSession`, and `(request as any).workspaceMember` casts across 20 files with direct typed property access, giving TypeScript visibility into these fields for autocompletion, rename refactors, and compile-time safety. No runtime behaviour changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/api/src/types/fastify.d.tsto extendFastifyRequestwith typeduser,authSession, andworkspaceMemberproperties(request as any).user,(request as any).authSession, and(request as any).workspaceMembercasts across 20 files(request.params as any).workspaceIdwith the narrower(request.params as { workspaceId?: string })cast in middlewareMotivation
The three properties are attached to
FastifyRequestat runtime by the auth and workspace middleware, but TypeScript had no knowledge of them — requiringas anycasts on every read. This PR registers the types once via Fastify's module-augmentation API so all access sites become typed.Test Plan