Generate CRDs#182
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 1616
💛 - Coveralls |
arjunrn
force-pushed
the
generate-crds
branch
6 times, most recently
from
0ef3f2b to
713da1f
Compare
arjunrn
force-pushed
the
generate-crds
branch
2 times, most recently
from
5afa391 to
2350bc4
Compare
arjunrn
force-pushed
the
generate-crds
branch
from
2350bc4 to
096a251
Compare
mikkeloscar
force-pushed
the
generate-crds
branch
6 times, most recently
from
fd6f363 to
9efb194
Compare
Signed-off-by: Arjun Naik <arjun@arjunnaik.in> Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
force-pushed
the
generate-crds
branch
from
9efb194 to
4b615b0
Compare
Closed
muaazsaleem
reviewed
Aug 19, 2020
| Weight float64 `json:"weight"` | ||
| StackName string `json:"stackName"` | ||
| // +kubebuilder:validation:Type=number | ||
| // +kubebuilder:validation:Format=float |
Contributor
There was a problem hiding this comment.
nit: Is this deliberately not float64? i.e // +kubebuilder:validation:Format=float64
Contributor
There was a problem hiding this comment.
Ah nvm, I see here that it's not a valid format.
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate CRDs using tools
Updated:
preserveUnknownFields: falsesuch that unknown fields gives a validation error.x-kubernetes-list-map-keys:which doesn't work: Default value not allowed for in x-kubernetes-list-map-keys kubernetes-sigs/controller-tools#444