Set runAsUser/runAsGroup/FSGroup on logical-backup job podtemplates #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timricese
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
erthalion and
sdudoladov
as code owners
|
Just ran in the non-root problem for logical backup container. Is there a plan to merge this change, or is there another way? |
|
Thanks @timricese. Let's do some more refactoring here. Can you move this code block (lines 1164 - 1178) inside generatePodTemplate function? We can then remove arguments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes logical-backup CronJobs be created with a securityContext containing
runAsUser,runAsGroupandFSGroupbased on the SpiloRunAsUser, SpiloRunAsGroup and SpiloFSGroup operator configuration options, allowing the logical-backup jobs to run as non-root.resolves #1306