Use UpdateStatus instead of patch #3005
Draft
+71
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
added
major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
postgresqlstatus update logic to useUpdateStatusinstead of Patch.The Purpose of this change is to make it simpler to extend the status field and update it via modifying the struct and allow updates of multiple status fields at a time.
For now there is still only the field:
PostgresClusterStatusso there is no functional change, but a follow up PR intend to add a newObservedGenerationfield.This also fixes a test case which silently ignored updating the status of a resource which was not in the API already. It does so by registering the postgresql resource in the fake client used for testing.