Set HUMAN_ROLE Spilo env var #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdudoladov
requested review from
CyberDem0n,
Jan-M,
alexeyklyukin,
avaczi and
erthalion
as code owners
Member
|
This looks good, but I would like to know that this cannot be put into the spilo config json, dont like additional env vars when we have a big config object already. |
Member
Author
that won't work, I've run a few experiments 😐 the current PR version with the env var works, though |
erthalion
reviewed
Feb 4, 2019
Jan-M
approved these changes
Feb 27, 2019
Member
Jan-M
left a comment
Jan-M
left a comment
There was a problem hiding this comment.
Future work to merge with spilo json env var to not clutter vars and json around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the env var
HUMAN_ROLEin a Spilo container; fixes #407