Merged
Conversation
Signed-off-by: patrickdk <patrickdk@patrickdk.com>
Signed-off-by: patrickdk <patrickdk@patrickdk.com>
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
szuecs
reviewed
Apr 4, 2026
| case "br": | ||
| return new(brotliWrapper) | ||
| case "zstd": | ||
| return new(zstdWrapper) |
Member
There was a problem hiding this comment.
If you initialize here the decoder then we don't need the runtime nil checks anymore.
szuecs
reviewed
Apr 4, 2026
| } | ||
|
|
||
| func (w *zstdWrapper) Reset(original io.Reader) error { | ||
| if w.Decoder == nil { |
Member
There was a problem hiding this comment.
please drop and init correctly in newDecoder
szuecs
reviewed
Apr 4, 2026
| } | ||
|
|
||
| func (w *zstdWrapper) Close() error { | ||
| if w.Decoder != nil { |
Member
There was a problem hiding this comment.
please drop and init correctly in newDecoder
szuecs
requested changes
Apr 4, 2026
Signed-off-by: patrickdk <patrickdk@patrickdk.com>
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Contributor
Author
|
Believe this addresses the request, my lack of go class understanding is showing |
szuecs
approved these changes
Apr 7, 2026
Member
|
Thanks lgtm |
Member
|
👍 |
This was referenced Apr 7, 2026
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 16, 2026
* zalando/skipper#3934 * zalando/skipper#3938 * zalando/skipper#3940 * zalando/skipper#3941 * zalando/skipper#3942 * zalando/skipper#3951 * zalando/skipper#3946 * zalando/skipper#3950 * zalando/skipper#3948 * zalando/skipper#3949 * zalando/skipper#3947 * zalando/skipper#3117 follow up on #10974 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds zstd support to compress and decompress filters without adding extra dependencies
Savings cpu processing time vs gzip, atleast almost all of my clients have zstd support