bugfix: routesrv return full routingTable with zone#3984
Merged
Conversation
In routeSRV, when we serve zone aware routes after `zone: r.PathValue("zone")`
we only update uncompressed data, while http.Client serves compressed data
by default. Which made all requests land in `gzip` branch later.
And `gzip` branch is serving `zdata` which was never updated with the new
routingTable.
This commit include a reproducer testcase and the fix is in the next commit.
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
…unt as it was also always returning the full routing table count Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
szuecs
approved these changes
Apr 25, 2026
Collaborator
|
👍🏽 |
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In routeSRV, when we serve zone aware routes after
zone: r.PathValue("zone")we only update uncompressed data, while http.Client serves compressed data by default. Which made all requests land ingzipbranch later.And
gzipbranch is servingzdatawhich was never updated with the new routingTable.This commit include a reproducer testcase and the fix is in the next commit.