Add support for WAL-E/WAL-G with custom PGPORT#582
Merged
CyberDem0n merged 1 commit intozalando:masterfrom May 14, 2021
Merged
Conversation
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Contributor
|
Merged, thank you @KarlHerler! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #571.
The comment: #571 (comment) was not sufficient as
PGPORTmust also be placed inwrite_envidir_namesor as implemented here.Note that the current implementation adds the
PGPORTfile to the WAL-E/WAL-G configuration files indiscriminately, even if it isn't necessary for default port use cases. This does not cause any problems but it is redundant.