#585 certificate rotation based on file hash, not modified time#599
Merged
CyberDem0n merged 3 commits intozalando:masterfrom Aug 12, 2021
Merged
Conversation
CyberDem0n
reviewed
Jul 14, 2021
Contributor
CyberDem0n
left a comment
CyberDem0n
left a comment
There was a problem hiding this comment.
And the shellcheck complains about your changes: https://github.com/zalando/spilo/pull/599/checks#step:6:7
| env = ' '.join('{0}="{1}"'.format(n, placeholders[n]) for n in ('PGDATA', 'SSL_CA_FILE', 'SSL_CRL_FILE', | ||
| 'SSL_CERTIFICATE_FILE', 'SSL_PRIVATE_KEY_FILE') if placeholders.get(n)) | ||
| lines += ['*/5 * * * * {0} /scripts/test_reload_ssl.sh 5'.format(env)] | ||
| lines += ['*/5 * * * * {0} /scripts/test_reload_ssl.sh /tmp'.format(env)] |
Contributor
There was a problem hiding this comment.
The /tmp directory is could be read-only if the container is in read-only.
It is better to use os.path.join(placeholders['RW_DIR'], 'tmp').
Contributor
Author
There was a problem hiding this comment.
Good point. I will make this change.
|
Any rough timeline for release of this? |
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the certificate reload scripts to be based on @bchrobots script change.
I have tested this and can verify that it works.